lint: ignore js file by jannyHou · Pull Request #4431 · loopbackio/loopback-next

jannyHou · 2020-01-14T18:12:04Z

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

jannyHou · 2020-01-14T18:12:53Z

  const config = {
    rest: {
      port: +process.env.PORT || 3000,
+      // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


The ts eslint rules like @typescript-eslint/prefer-nullish-coalescing shouldn't check js file

Is it required for the build to pass? We already have this override - https://github.com/strongloop/loopback-next/blob/master/packages/eslint-config/eslintrc.js#L158

@raymondfeng Not really, our code base is good, and adding this line results in lint error...
But the todo example created by lb4 example complains:

lb4 example (choose todo) cd loopback4-example-todo npm i npm run lint > @loopback/example-todo@1.9.4 lint /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo > npm run prettier:check && npm run eslint > @loopback/example-todo@1.9.4 prettier:check /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo > npm run prettier:cli -- -l > @loopback/example-todo@1.9.4 prettier:cli /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo > lb-prettier "**/*.ts" "-l" > @loopback/example-todo@1.9.4 eslint /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo > lb-eslint --report-unused-disable-directives . /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo/index.js 15:30 error Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator @typescript-eslint/prefer-nullish-coalescing ✖ 1 problem (1 error, 0 warnings) 1 error and 0 warnings potentially fixable with the `--fix` option.

I see. I wonder why https://github.com/strongloop/loopback-next/blob/master/packages/eslint-config/eslintrc.js#L158 does not exclude js files. Can you check which version of @loopback/eslint-config is pulled in?

@raymondfeng It's already on the latest released version @loopback/eslint-config@5.0.1

Maybe add a file similar as https://github.com/strongloop/loopback4-example-shopping/blob/d0f6d7543c1a861dc4a4281b6ef7b8ac8d1085dc/.eslintrc.js?

@raymondfeng 👍 tested the config file, I think the necessary config is extends: ['@loopback/eslint-config']

Details verified in comment #4431 (comment)

jannyHou · 2020-01-14T21:22:46Z

Verified with the latest cloned todo example:

before adding the .eslintrc.js file
jannyHous-MacBook-Pro:loopback4-example-todo jannyhou$ npm run lint

> @loopback/example-todo@1.9.4 lint /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> npm run prettier:check && npm run eslint


> @loopback/example-todo@1.9.4 prettier:check /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> npm run prettier:cli -- -l


> @loopback/example-todo@1.9.4 prettier:cli /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> lb-prettier "**/*.ts" "-l"


> @loopback/example-todo@1.9.4 eslint /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> lb-eslint --report-unused-disable-directives .


/Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo/index.js
  15:30  error  Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator  @typescript-eslint/prefer-nullish-coalescing

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @loopback/example-todo@1.9.4 eslint: `lb-eslint --report-unused-disable-directives .`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @loopback/example-todo@1.9.4 eslint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jannyhou/.strong-registry/official.cache/_logs/2020-01-14T21_08_58_677Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @loopback/example-todo@1.9.4 lint: `npm run prettier:check && npm run eslint`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @loopback/example-todo@1.9.4 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jannyhou/.strong-registry/official.cache/_logs/2020-01-14T21_08_58_705Z-debug.log

jannyHous-MacBook-Pro:loopback4-example-todo jannyhou$ npm run clean

> @loopback/example-todo@1.9.4 clean /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> lb-clean *example-todo*.tgz dist tsconfig.build.tsbuildinfo package

after adding the .eslintrc.js file
jannyHous-MacBook-Pro:loopback4-example-todo jannyhou$ npm run lint

> @loopback/example-todo@1.9.4 lint /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> npm run prettier:check && npm run eslint


> @loopback/example-todo@1.9.4 prettier:check /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> npm run prettier:cli -- -l


> @loopback/example-todo@1.9.4 prettier:cli /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> lb-prettier "**/*.ts" "-l"


> @loopback/example-todo@1.9.4 eslint /Users/jannyhou/Desktop/2019/ui/test/loopback4-example-todo
> lb-eslint --report-unused-disable-directives .

jannyHou requested review from bajtos and hacksparrow as code owners January 14, 2020 18:12

jannyHou commented Jan 14, 2020

View reviewed changes

jannyHou force-pushed the lint/todo-example branch from a460bd5 to f0ef5fc Compare January 14, 2020 20:51

raymondfeng approved these changes Jan 14, 2020

View reviewed changes

jannyHou force-pushed the lint/todo-example branch from f0ef5fc to 1a17242 Compare January 14, 2020 21:17

jannyHou force-pushed the lint/todo-example branch from 1a17242 to 34ea4f1 Compare January 14, 2020 21:44

chore: ignore js file

4852884

jannyHou force-pushed the lint/todo-example branch from 34ea4f1 to 4852884 Compare January 14, 2020 22:37

jannyHou self-assigned this Jan 14, 2020

jannyHou merged commit 51370bc into master Jan 15, 2020

jannyHou deleted the lint/todo-example branch January 15, 2020 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

lint: ignore js file#4431

lint: ignore js file#4431
jannyHou merged 1 commit into
masterfrom
lint/todo-example

jannyHou commented Jan 14, 2020 •

edited

Loading

Uh oh!

jannyHou Jan 14, 2020

Uh oh!

raymondfeng Jan 14, 2020

Uh oh!

jannyHou Jan 14, 2020

Uh oh!

raymondfeng Jan 14, 2020

Uh oh!

jannyHou Jan 14, 2020

Uh oh!

raymondfeng Jan 14, 2020

Uh oh!

jannyHou Jan 14, 2020

Uh oh!

jannyHou commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jannyHou commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

jannyHou Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

raymondfeng Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

jannyHou Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

raymondfeng Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

jannyHou Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

raymondfeng Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

jannyHou Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

jannyHou commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jannyHou commented Jan 14, 2020 •

edited

Loading